Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Github action for integration test #896

Closed
wants to merge 17 commits into from
Closed

Add Github action for integration test #896

wants to merge 17 commits into from

Conversation

JCZuurmond
Copy link
Collaborator

@JCZuurmond JCZuurmond commented Sep 29, 2023 •
edited
Loading

Part of resolving #719

Problem

Removing the dependency on CircleCI

Solution

Use Github Actions

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@cla-bot cla-bot bot added the cla:yes label Sep 29, 2023
@JCZuurmond JCZuurmond force-pushed the add-github-workflow-for-integration-tests branch 3 times, most recently from 3a26cf3 to a80d2d2 Compare September 29, 2023 09:38
@JCZuurmond JCZuurmond force-pushed the add-github-workflow-for-integration-tests branch from a80d2d2 to fd6f6f0 Compare September 29, 2023 09:41
@JCZuurmond JCZuurmond force-pushed the add-github-workflow-for-integration-tests branch from 212f828 to 915f67e Compare September 29, 2023 12:59
JCZuurmond
JCZuurmond commented Sep 29, 2023
View reviewed changes
docker/Dockerfile
@@ -2,8 +2,8 @@ ARG OPENJDK_VERSION=8
FROM eclipse-temurin:${OPENJDK_VERSION}-jre

ARG BUILD_DATE
ARG SPARK_VERSION=3.3.2
ARG HADOOP_VERSION=3
ARG SPARK_VERSION=3.1.3
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests do not work yet for a later version. We will solve that later. This is the same version as in the Dockerfile used in the circle ci

@JCZuurmond JCZuurmond marked this pull request as ready for review September 29, 2023 14:12
@JCZuurmond JCZuurmond requested a review from a team as a code owner September 29, 2023 14:12
@JCZuurmond
Copy link
Collaborator Author

The ci/circleci: integration-spark-thrift is unrelated to this PR. And actually solved by providing the Github action!

@colin-rogers-dbt
Copy link
Contributor

Going to take this and add some stuff we use in other repos + databricks integ test setup in #923

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fokko Fokko Fokko left review comments

@dataders dataders Awaiting requested review from dataders

@emmyoop emmyoop Awaiting requested review from emmyoop

@mikealfare mikealfare Awaiting requested review from mikealfare mikealfare is a code owner automatically assigned from dbt-labs/adapters

Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JCZuurmond @colin-rogers-dbt @Fokko @Fleid